Skip to content

Comments

swev-id: scikit-learn__scikit-learn-13496 expose warm start for IsolationForest#33

Open
casey-brooks wants to merge 1 commit intoscikit-learn__scikit-learn-13496from
feature/iforest-warm-start-30
Open

swev-id: scikit-learn__scikit-learn-13496 expose warm start for IsolationForest#33
casey-brooks wants to merge 1 commit intoscikit-learn__scikit-learn-13496from
feature/iforest-warm-start-30

Conversation

@casey-brooks
Copy link

@casey-brooks casey-brooks commented Dec 26, 2025

Summary

  • expose the warm_start parameter in IsolationForest and forward it to BaseBagging
  • document IsolationForest warm-start behavior in the user guide and example
  • add coverage for warm_start growth, warnings, and determinism in tests

Testing

  • source /workspace/sklearn-py37/bin/activate && flake8 sklearn/ensemble/iforest.py sklearn/ensemble/tests/test_iforest.py
  • source /workspace/sklearn-py37/bin/activate && LD_LIBRARY_PATH=/nix/store/y1bnyxikip76b1nk1adjabnx67pwkl36-libxcrypt-4.5.2/lib:/nix/store/gh2dd8vimringn726ndall19gbm77prj-openblas-0.3.30/lib:/nix/store/y6zrr7dfg051mz4dpjvaldy4g9cy6wmq-lapack-3/lib:/nix/store/4wdz42ns29ys6fm1xak68bnp51nxhd2s-zlib-1.3.1/lib pytest sklearn/ensemble/tests/test_iforest.py

Closes #30

@casey-brooks casey-brooks requested a review from a team December 26, 2025 02:15
@casey-brooks
Copy link
Author

casey-brooks commented Dec 26, 2025

Local validation

  • source /workspace/sklearn-py37/bin/activate && flake8 sklearn/ensemble/iforest.py sklearn/ensemble/tests/test_iforest.py → no issues
  • source /workspace/sklearn-py37/bin/activate && LD_LIBRARY_PATH=/nix/store/y1bnyxikip76b1nk1adjabnx67pwkl36-libxcrypt-4.5.2/lib:/nix/store/gh2dd8vimringn726ndall19gbm77prj-openblas-0.3.30/lib:/nix/store/y6zrr7dfg051mz4dpjvaldy4g9cy6wmq-lapack-3/lib:/nix/store/4wdz42ns29ys6fm1xak68bnp51nxhd2s-zlib-1.3.1/lib pytest sklearn/ensemble/tests/test_iforest.py → 24 passed, 0 failed

noa-lucent
noa-lucent approved these changes Dec 26, 2025
View reviewed changes
Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good—docs, implementation, and warm_start coverage all check out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noa-lucent noa-lucent noa-lucent approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@casey-brooks @noa-lucent